Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kamaji version #633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update kamaji version #633

wants to merge 1 commit into from

Conversation

lllamnyp
Copy link
Member

@lllamnyp lllamnyp commented Feb 18, 2025

Summary by CodeRabbit

  • Chores
    • Adjusted the Kubernetes ingress configuration by removing a hardcoded port for more flexible hostname routing.
    • Upgraded the container build to a newer application version and enhanced patch handling.
    • Updated deployment settings to pull the latest container image, ensuring up-to-date components.

* Stripped port number from KamajiControlPlane hostname due to clastix/kamaji#679
* Bumped versions for kamaji and dependent charts
@lllamnyp lllamnyp requested a review from kvaps as a code owner February 18, 2025 07:52
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2025
Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

Walkthrough

This pull request modifies three configuration files. It removes the hardcoded port from the hostname in the ingress configuration of the Kubernetes cluster template. Simultaneously, it upgrades the Kamaji application version in the Dockerfile and updates the patch application command. In the associated values file, the image tag is switched from a specific version with a digest to a "latest" digest reference. No changes to control flow or public APIs were introduced.

Changes

File(s) Change Summary
packages/apps/.../cluster.yaml Removed the hardcoded :443 from the hostname in the ingress section of the KamajiControlPlane resource
packages/system/kamaji/... (Dockerfile & values.yaml) Upgraded Kamaji version (ARG VERSION: edge-24.9.2 → edge-24.12.1) with an updated patch command in Dockerfile, and switched the image tag to latest with a new SHA256 digest in values.yaml

Possibly related PRs

  • Revert kamaji edge-24.12.1 #610: Addresses Dockerfile version modifications by reverting the Kamaji version to an earlier state, directly relating to the version updates in this PR.

Suggested labels

enhancement, size:M

Suggested reviewers

  • kvaps
  • themoriarti

Poem

Hoppin' through the code I roam,
Removing ports to free our home.
New versions bloom in every line,
Patches scattered, coded fine.
I nibble bytes with bunny cheer,
Celebrating changes far and near! 🐰💻


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d5b22e and a31c3a5.

⛔ Files ignored due to path filters (1)
  • packages/system/kamaji/charts/kamaji/Chart.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • packages/apps/kubernetes/templates/cluster.yaml (1 hunks)
  • packages/system/kamaji/images/kamaji/Dockerfile (1 hunks)
  • packages/system/kamaji/values.yaml (1 hunks)
🔇 Additional comments (4)
packages/system/kamaji/values.yaml (1)

6-6: Updated Image Tag with Latest Digest

The tag field has been updated to
latest@sha256:04aaf9acb6f49e0315295cd0c24655f28b74c6cf628fc6721758842a41d2deef
which now points to a "latest" digest rather than a fixed version. This change must be intentional—using the latest image can cause deployments to pull future releases automatically. Verify that this aligns with your release and stability strategies.

packages/system/kamaji/images/kamaji/Dockerfile (2)

4-4: Bump Kamaji Version in Dockerfile

The build argument VERSION has been updated to edge-24.12.1, which correctly bumps the Kamaji application to the newer version as described in the PR objectives. Ensure that this version is compatible with your patches and downstream dependencies.


11-12: Apply Multiple Patch Files

The Dockerfile now applies all .diff files under /patches via the command
RUN git apply /patches/*.diff
instead of applying a single hardcoded patch file. This broadens the scope of applied patches. Just verify that the ordering and content of these patches are well controlled to avoid unintended modifications.

packages/apps/kubernetes/templates/cluster.yaml (1)

120-121: Remove Hardcoded Port from Hostname

The ingress hostname configuration has been updated to
hostname: {{ .Values.host | default (printf "%s.%s" .Release.Name $host) }}
which strips out any hardcoded port number. This aligns with the PR objective of removing the port from the KamajiControlPlane hostname. Verify that the new hostname construction meets your routing and DNS expectations.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added the enhancement New feature or request label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant