Work in env without window.location #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environments like React Native don't have a window.location. In such an environment, boot-reload fails because window.location.hostname or .protocol does not exist. Use some-> to avoid these exceptions.
|
At some point there was a PR doing something similar to support this for
webworkers. Maybe that's not released yet but already solved somewhere in
the codebase..?
…On Sat, 24 Dec 2016 at 21:46, Paulus Esterhazy ***@***.***> wrote:
Environments like React Native don't have a window.location. In such an
environment, boot-reload fails because window.location.hostname or
.protocol does not exist. Use some-> to avoid these exceptions.
------------------------------
You can view, comment on, or merge this pull request online at:
#110
Commit Summary
- Work in env without window.location
File Changes
- *M* src/adzerk/boot_reload/client.cljs
<https://github.com/adzerk-oss/boot-reload/pull/110/files#diff-0> (2)
- *M* src/adzerk/boot_reload/reload.cljs
<https://github.com/adzerk-oss/boot-reload/pull/110/files#diff-1> (2)
Patch Links:
- https://github.com/adzerk-oss/boot-reload/pull/110.patch
- https://github.com/adzerk-oss/boot-reload/pull/110.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#110>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF82ITxsGzKxegThK56diTR30Pfygmoks5rLSIxgaJpZM4LVOpD>
.
|
|
In any case this change is not very invasive and I can't think of a way in
which this could break existing code.
…On Dec 24, 2016 15:20, "Martin Klepsch" ***@***.***> wrote:
At some point there was a PR doing something similar to support this for
webworkers. Maybe that's not released yet but already solved somewhere in
the codebase..?
On Sat, 24 Dec 2016 at 21:46, Paulus Esterhazy ***@***.***>
wrote:
> Environments like React Native don't have a window.location. In such an
> environment, boot-reload fails because window.location.hostname or
> .protocol does not exist. Use some-> to avoid these exceptions.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #110
> Commit Summary
>
> - Work in env without window.location
>
> File Changes
>
> - *M* src/adzerk/boot_reload/client.cljs
> <https://github.com/adzerk-oss/boot-reload/pull/110/files#diff-0> (2)
> - *M* src/adzerk/boot_reload/reload.cljs
> <https://github.com/adzerk-oss/boot-reload/pull/110/files#diff-1> (2)
>
> Patch Links:
>
> - https://github.com/adzerk-oss/boot-reload/pull/110.patch
> - https://github.com/adzerk-oss/boot-reload/pull/110.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#110>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AAF82ITxsGzKxegThK56diTR30Pfygmoks5rLSIxgaJpZM4LVOpD>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGfWGGMXvtBUpI2UfUz_HKxepr_OWExks5rLSo3gaJpZM4LVOpD>
.
|
|
Probably this doesn't break anything. But does this fix anything either? with React-native or other environments? The reload mechanism currently only loads the files by appending |
|
@Deraen, yes! We've been using boot-reload very happily in boot-react-native for a year or more. We have code that patches Google Closure's mechanism with a custom eval-based js loader: The context of this PR: We currently shim |
|
Okay, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environments like React Native don't have a window.location. In such an
environment, boot-reload fails because window.location.hostname or
.protocol does not exist. Use some-> to avoid these exceptions.