Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALPS Theme setting design for supporting footer localizatinon #627

Closed
YauheniKapliarchuk opened this issue Jan 12, 2023 · 11 comments
Closed
Assignees
Labels
ALPS v.3 Tickets for the ALPS v.3 development

Comments

@YauheniKapliarchuk
Copy link
Collaborator

Hi,

in this ticket I did some investigation this issue.
After call with @designerbrent we decided to do:

  • update design our ALPS Theme Settings (add new tabs for supported languages);
  • provide new fields of these changes to backend side and adaptive it for supported languages.

First part - prepare some template for team for confirmation approach.

Thanks,
Best Regards!

@designerbrent @daniel-eesti @hans-olson @johnrbeckett

@YauheniKapliarchuk YauheniKapliarchuk added the ALPS v.3 Tickets for the ALPS v.3 development label Jan 12, 2023
@YauheniKapliarchuk YauheniKapliarchuk self-assigned this Jan 12, 2023
@johnrbeckett
Copy link
Contributor

let's see a mockup of how this would look

@YauheniKapliarchuk
Copy link
Collaborator Author

YauheniKapliarchuk commented Jan 23, 2023

Hi Team,

I am prepared a mockup for this functionality.
I was wondering if you check it and give your feedback
1.png2.png

Thanks,
Best Regards!

CC: @johnrbeckett @designerbrent @hans-olson

@johnrbeckett
Copy link
Contributor

Let's not do a "translate" tab. Instead, put the translatable languages underneath the header for the tab, for example "english, german, spanish, etc" would go underneath the line "Theme Color Options Grid" on the "Global" tab.

@YauheniKapliarchuk
Copy link
Collaborator Author

Hi @johnrbeckett for your comment

I did another one mockup

2023-01-24 16.41.36.jpg

@designerbrent
Copy link
Collaborator

  • The language buttons should look like tabs, and then show the content of the tab underneath.
  • Do you plan to move all the fields that have text in them to one place or will you put the language buttons under each tab and around each translatable field?

@YauheniKapliarchuk
Copy link
Collaborator Author

Hi @designerbrent
here presents 2 approaches. Second was chosen by John and Hans

Would do you prefer?

Thanks,
Best Regards!

@designerbrent
Copy link
Collaborator

designerbrent commented Jan 25, 2023

I guess my questions still stand as I’m a little confused by both interfaces. @YauheniKapliarchuk

@YauheniKapliarchuk
Copy link
Collaborator Author

YauheniKapliarchuk commented Jan 30, 2023

Hi @designerbrent

Let me try to explain

At the moment, there are 2 options for how we can arrange the management of the translation of fields for several languages.

  1. Make a separate tab ("Translate") and move all the necessary translated fields into this tab.
  2. Second way is to place the tabs languages ("En", "Es", "De") above each field/group fields that will be translatable.

The last thing we decided was to put the language buttons under each tab and around each translatable field.

I hope I answered your question...

If anything, we will have a weekly meeting tomorrow, let's brainstorm this task together?

Thanks,
Best Regards!

@johnrbeckett
Copy link
Contributor

Hi All, We're going to go with the second mockup with the blue buttons under each tab where translation options are available.

@designerbrent
Copy link
Collaborator

I think that makes sense. Overall, I prefer the idea of that to the first option of having a different tab for translatable things. Will there be a bar of language buttons on each field that can be translated or just one per tab?

YauheniKapliarchuk pushed a commit that referenced this issue Sep 8, 2023
Changes:
- update default phrase for footer and statement;
- add new element in "ALPS theme settings" to "Footer" tab;
- add default phrases for different languages;
- increase version of ALPS.

#627-Add-footer-localization
YauheniKapliarchuk pushed a commit that referenced this issue Sep 12, 2023
Changes:
- update default phrase for footer and statement;
- add new element in "ALPS theme settings" to "Footer" tab;
- add default phrases for different languages;
- increase version of ALPS.

#627-Add-footer-localization
@YauheniKapliarchuk
Copy link
Collaborator Author

Hi everyone

This functionality was released in this release 3.15.1.2.

Thanks,
Best Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALPS v.3 Tickets for the ALPS v.3 development
Projects
None yet
Development

No branches or pull requests

3 participants