Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Disable WPML menu #548

Closed
designerbrent opened this issue Jan 14, 2021 · 3 comments
Closed

Option to Disable WPML menu #548

designerbrent opened this issue Jan 14, 2021 · 3 comments
Assignees

Comments

@designerbrent
Copy link
Collaborator

designerbrent commented Jan 14, 2021

We need the option to disable the WPML language menu that shows by default when the WPML plugin is installed. Currently, the theme is setup to look for WPML being installed and then display this menu on it's own, with no way to control it. I would like a way to do one of the following:

  • Use the native WPML functionality to display the menu.
  • Provide an option in ALPS to enable/disable this function.

2021-01-14 at 1 54 PM

YauheniKapliarchuk added a commit to YauheniKapliarchuk/alps-wordpress that referenced this issue Apr 7, 2021
@YauheniKapliarchuk
Copy link
Collaborator

Hi @designerbrent

This is my PR for adding this feature

#566

Thanks!

YauheniKapliarchuk added a commit that referenced this issue Apr 18, 2021
[#548] Option to Disable WPML menu.
@designerbrent
Copy link
Collaborator Author

Last night we had to make an HOTFIX release on ALPS for Wordpress and I see this morning at the error we talked about last week slipped into the release, likely related to the WPML branch that you merged in.

2021-04-21 at 2 41 PM

Please see about resolving this issue as soon as possible, since that is now rolling out to active sites.

@designerbrent
Copy link
Collaborator Author

Here is a list of the other changes that need to be made to fix this:

Changes to WPML settings:

  • If WPML is not active, don't show the settings.
    2021-04-19 at 6 48 AM
  • Change the settings name to WPML Language Selector Settings

YauheniKapliarchuk added a commit to YauheniKapliarchuk/alps-wordpress that referenced this issue Apr 21, 2021
YauheniKapliarchuk added a commit to YauheniKapliarchuk/alps-wordpress that referenced this issue Apr 21, 2021
YauheniKapliarchuk added a commit to YauheniKapliarchuk/alps-wordpress that referenced this issue Apr 21, 2021
YauheniKapliarchuk added a commit to YauheniKapliarchuk/alps-wordpress that referenced this issue Apr 21, 2021
YauheniKapliarchuk added a commit to YauheniKapliarchuk/alps-wordpress that referenced this issue Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants