Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with 3.2.0 udpate #455

Closed
designerbrent opened this issue Apr 15, 2020 · 1 comment · Fixed by #456
Closed

Error with 3.2.0 udpate #455

designerbrent opened this issue Apr 15, 2020 · 1 comment · Fixed by #456
Assignees
@tpitre @kelscahill
Labels
ALPS v.3 Tickets for the ALPS v.3 development bug URGENT

Comments

@designerbrent
Copy link
Collaborator

After pulling this updated (#446) and deploying it, I found an error that I forgot to test for before deploying this. When the Half screen image gallery with text overlay option, it breaks, leaving not a slideshow, but some images and a misformed page. From the looks of it, it appears that the HTML got broken at the wrong place.

2020-04-15 at 1 37 PM
@designerbrent designerbrent added bug ALPS v.3 Tickets for the ALPS v.3 development URGENT labels Apr 15, 2020
kelscahill added a commit that referenced this issue Apr 15, 2020
@kelscahill
#455 Fix for carousel hero
869881c
@kelscahill kelscahill mentioned this issue Apr 15, 2020
Merged
@kelscahill
Copy link
Collaborator

@designerbrent Just letting you know a PR was created for this issue here: #456

designerbrent added a commit that referenced this issue Apr 15, 2020
@designerbrent
Merge pull request #456 from adventistchurch/v3.445-new-hero-header-o…
1e5009a 
…ption

#455 Fix for carousel hero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpitre tpitre

@kelscahill kelscahill

Labels
ALPS v.3 Tickets for the ALPS v.3 development bug URGENT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#455 Fix for carousel hero adventistchurch/alps-wordpress
3 participants
@designerbrent @tpitre @kelscahill