Skip to content

Commit

Permalink
bpo-42794: Update test_nntplib to use offical group name for testing (p…
Browse files Browse the repository at this point in the history
  • Loading branch information
corona10 authored and adorilson committed Mar 11, 2021
1 parent d82242c commit bcb704a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 7 additions & 3 deletions Lib/test/test_nntplib.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _check_desc(desc):
desc = self.server.description(self.GROUP_NAME)
_check_desc(desc)
# Another sanity check
self.assertIn("Python", desc)
self.assertIn(self.DESC, desc)
# With a pattern
desc = self.server.description(self.GROUP_PAT)
_check_desc(desc)
Expand Down Expand Up @@ -309,6 +309,7 @@ class NetworkedNNTPTests(NetworkedNNTPTestsMixin, unittest.TestCase):
NNTP_HOST = 'news.trigofacile.com'
GROUP_NAME = 'fr.comp.lang.python'
GROUP_PAT = 'fr.comp.lang.*'
DESC = 'Python'

NNTP_CLASS = NNTP

Expand Down Expand Up @@ -343,8 +344,11 @@ class NetworkedNNTP_SSLTests(NetworkedNNTPTests):
# 400 connections per day are accepted from each IP address."

NNTP_HOST = 'nntp.aioe.org'
GROUP_NAME = 'comp.lang.python'
GROUP_PAT = 'comp.lang.*'
# bpo-42794: aioe.test is one of the official groups on this server
# used for testing: https://news.aioe.org/manual/aioe-hierarchy/
GROUP_NAME = 'aioe.test'
GROUP_PAT = 'aioe.*'
DESC = 'test'

NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Update test_nntplib to use offical group name of news.aioe.org for testing.
Patch by Dong-hee Na.

0 comments on commit bcb704a

Please sign in to comment.