Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to the old linux cross compile filter #2327

Merged
merged 3 commits into from
Dec 22, 2020
Merged

Revert to the old linux cross compile filter #2327

merged 3 commits into from
Dec 22, 2020

Conversation

M-Davies
Copy link

Fixes : #2325
Signed-off-by: Morgan Davies [email protected]

@M-Davies M-Davies added buildbreak High priority issues that cause build breaks in jenkins or build scripts cross-compile Issues that affect or relate to cross compiled platforms (e.g. RISC-V) labels Dec 21, 2020
sxa
sxa approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for test/debug purposes

@karianna karianna added this to the December 2020 milestone Dec 21, 2020
@M-Davies M-Davies requested a review from karianna December 22, 2020 09:09
@sxa
Copy link
Member

sxa commented Dec 22, 2020

Looks like it's using that filter as a parameter to the tar xf command. The behaviour has changed in #2117 to modify the filter used in all cases to include the **/ prefix, so at the moment this seems a viable fix. @andrew-m-leonard Are you able to approve this given that @karianna is on vacation (and his concerns - related to if we were to cross-compile on macos/aarch64 in the future - have now been addressed)

@gdams gdams merged commit e3101ce into adoptium:master Dec 22, 2020
@M-Davies M-Davies deleted the cross_compile branch April 30, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@gdams gdams gdams approved these changes

@karianna karianna Awaiting requested review from karianna

Assignees
No one assigned
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts cross-compile Issues that affect or relate to cross compiled platforms (e.g. RISC-V)
Projects
None yet
Milestone
December 2020
Development

Successfully merging this pull request may close these issues.

JDK11/J9/RISC-V builds broken
4 participants
@M-Davies @sxa @karianna @gdams