Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPB: Fix Problematic Centos6 Downloads #3878

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Feb 11, 2025

Fixes #3839

Downloads for Git Source and Nvidia Cuda toolkit are failing on CentOS6 due to the certificate errors, and the lack of support of SNI enabled validation, due to the age of the O/S.

This PR adds an alternative, but still secure download mechanism for CentOS6 only, to allow the playbook to be backwards compatible.

Checklist

VPC In Progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2061/

@steelhead31 steelhead31 marked this pull request as ready for review February 11, 2025 22:13
@karianna karianna requested a review from sxa February 12, 2025 00:55
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor points and one thought (which I wouldn't address in this PR regardless): Is it worth just using wget/curl everywhere instead of having this duplicated?

@steelhead31
Copy link
Contributor Author

A couple of minor points and one thought (which I wouldn't address in this PR regardless): Is it worth just using wget/curl everywhere instead of having this duplicated?

Ansible doesnt particularly like commands being delegated to the shell, it prefers the get_url function... but definitely something to consider.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the ansible_distribution in ["CentOS", "RedHat"] syntax works everywhere we run ansible then I'm ok with this (Not sure we're written the expressions like that anywhere else)

Revert "UnixPB: Add RHEL clause to git download method"

This reverts commit 82190f1.

UnixPB: Add RHEL6 clause for Git_Source Download
@steelhead31
Copy link
Contributor Author

As long as the ansible_distribution in ["CentOS", "RedHat"] syntax works everywhere we run ansible then I'm ok with this (Not sure we're written the expressions like that anywhere else)

I've just encountered an issue with this syntax, despite it working ok locally, I've amended it to be more uniform.

@steelhead31 steelhead31 merged commit 7673849 into adoptium:master Feb 14, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS6 cannot download from https://www.kernel.org in GIT_Source role
3 participants