-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Fix Problematic Centos6 Downloads #3878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor points and one thought (which I wouldn't address in this PR regardless): Is it worth just using wget/curl everywhere instead of having this duplicated?
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/GIT_Source/tasks/main.yml
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/GIT_Source/tasks/main.yml
Outdated
Show resolved
Hide resolved
…tasks/main.yml Co-authored-by: Stewart X Addison <[email protected]>
Ansible doesnt particularly like commands being delegated to the shell, it prefers the get_url function... but definitely something to consider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the ansible_distribution in ["CentOS", "RedHat"]
syntax works everywhere we run ansible then I'm ok with this (Not sure we're written the expressions like that anywhere else)
Revert "UnixPB: Add RHEL clause to git download method" This reverts commit 82190f1. UnixPB: Add RHEL6 clause for Git_Source Download
b159a7b
to
ed6d03c
Compare
I've just encountered an issue with this syntax, despite it working ok locally, I've amended it to be more uniform. |
Fixes #3839
Downloads for Git Source and Nvidia Cuda toolkit are failing on CentOS6 due to the certificate errors, and the lack of support of SNI enabled validation, due to the age of the O/S.
This PR adds an alternative, but still secure download mechanism for CentOS6 only, to allow the playbook to be backwards compatible.
Checklist
VPC In Progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2061/