-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: switch alpine builds to use temurin boot jdk where possible #2568
base: master
Are you sure you want to change the base?
Conversation
JDK19_BOOT_DIR="/usr/lib/jvm/zulu18" \ | ||
JDKLATEST_BOOT_DIR="/usr/lib/jvm/zulu18" \ | ||
JAVA_HOME="/usr/lib/jvm/zulu8" | ||
JDK7_BOOT_DIR="/usr/lib/jvm/jdk-7" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one going to be pointing anywhere useful? I'd be tempted to hold off a bit on these changes until we've verified they work properly. I get the impression the JDK11 in particular may be causing the hangs on the test jobs as some of the later versions don't seem to be freezing so much at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I switched the Zulu 7 build to be installed there for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted this PR as not having been merged. I'm having a look at it and it looks like it's trying to symlink zulu into /usr/lib/jvm/jdk-xx
, yet it removes the zulu downloads.
Also the - ansible_distribution != "Alpine"
in the top level for the adoptopenjdk_install role seems to actively stop it trying to install the Temurin JDKs on Alpine. Am I missing something?
@gdams Will need a rebase |
@gdams Still worth keeping this open? |
Checklist