Block aqa and tck tests if smoke tests fail or are unstable.

[sophia-guo]

Close #121

Signed-off-by: Sophia Guo [email protected]

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

[smlambert]

LGTM, added some suggestions for the typos that pre-existed in the adjusted code.

[sophia-guo]

Need a second thought, change it to draft

[andrew-m-leonard]

Changes look good

[andrew-m-leonard]

@smlambert At the moment jdk8 alpineLinux Smoke tests fail due to:

19:17:04  /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-alpine-linux-x64-temurin_SmokeTests/aqa-tests/TKG/envSettings.mk:34: *** DETECTED_JDK_VERSION value is 17, settled JDK_VERSION value is 8. JDK_VERSION value does not match. Please reset or unset JDK_VERSION.  Stop.

So with this change we won't be able to run tests on jdk8 Alpine ? I guess we can run manually instead?

[smlambert]

Argh! That smoke test failure relates to adoptium/infrastructure#2934 for which there is a workaround on the test side, though I kind of wanted to see a resolution via the infra containers that we are exclusively using for test.

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅

[sophia-guo]

@smlambert @andrew-m-leonard I have updated the PR to set propagate=false and explicitly set the build_pipeline job result by the smoketest job result. Otherwise there is no way to get the downstream job status is it fails and it will also fail the build step immediately ( we are using the catchError to avoid this now) https://issues.jenkins.io/browse/JENKINS-48475?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&showAll=true

Same issue with #683