Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Docker builds from main build pipelines #46

Closed
smlambert opened this issue Jun 17, 2019 · 4 comments
Closed

Trigger Docker builds from main build pipelines #46

smlambert opened this issue Jun 17, 2019 · 4 comments

Comments

@smlambert
Copy link
Contributor

Currently Docker builds are triggered via a schedule separate from the main build pipelines. This issue is to discuss whether we initiate those builds from the main build pipelines.

Related: adoptium/aqa-tests#773 - we currently trigger Docker image testing off of the main build pipelines, which is incorrect, as there may not be a new Docker image to test, if the Docker build was not run.

@M-Davies
Copy link

M-Davies commented Apr 3, 2020

The way I see it, there’s two ways you could do this

  1. Have a check in the build_base to see if we’re building docker or a normal pipeline. Then execute build_all.sh if it is docker or carry on the pipeline as normal if not. Im not sure how transferable this could be however. The parameters for build_docker_multiarch seem simple enough to adapt to the normal pipelines but im not sure if there’s anything in build_all.sh that could interfere or outright break the normal pipelines. Best to get @johnoliver or @sxa555 to comment on that one.
  2. Adapt the build_all.sh script to be a groovy jenkins script instead of a bash script and have it run parallel with the normal pipelines from build_base. That would require a lot more effort to adapt the script but it might result in a faster and more efficient solution at the end as the whole docker pipeline would have been looked at for bugs and it will mean the docker repo could be fully moved in the build repo.

@sxa
Copy link
Member

sxa commented Apr 3, 2020

If we add it to the pipelines just now it will cause a significant delay in the overnight builds due to the length of time required to build all the images (3-24 hours at the moment). I would not be keen to slow the overnight build pipelines down in this way at present ... Thoughts? I am looking at the performance of those pipelines (I have new x64 machines for docker which have speeded those ones up in the last week)

@sxa
Copy link
Member

sxa commented Apr 3, 2020

Tagging in @dinogun on this conversation too :-)

@M-Davies M-Davies transferred this issue from adoptium/temurin-build Feb 18, 2021
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this issue Feb 8, 2022
@smlambert
Copy link
Contributor Author

This is no longer needed (given the Github workflow now in place that works well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants