Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Jlink tests #5992

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Remove Jlink tests #5992

merged 1 commit into from
Mar 6, 2025

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Feb 28, 2025 •
edited
Loading

This PR removes the JLink tests (Jlink_ReqMod, Jlink_AddMLimitM, and Jlink_GenOpt) from the playlist because the corresponding com.test.jlink tests in the system test (aqa-systemtest) be removed as in PR #498.
This change is made to eliminate native dependencies from the system test. It moves the Jlink tests out of the system test
This PR should be merged alongside PR:adoptium/aqa-systemtest#498.

related: #5965

@annaibm annaibm mentioned this pull request Feb 28, 2025
Open
4 tasks
@annaibm
Remove JlinkTests
e5ebc49 
- Remove the Jlink tests `Jlink_ReqMod`,`Jlink_AddMLimitM`,`Jlink_GenOpt`
 as the com.test.jlink from system test is removed.

 related: adoptium#5965

 Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm force-pushed the excludeJlinkTests branch from b07c9dd to e5ebc49 Compare March 3, 2025 17:51
@annaibm annaibm changed the title Disable Jlink tests Remove Jlink tests Mar 5, 2025
@annaibm
Copy link
Contributor Author

annaibm commented Mar 5, 2025

Grinder runs:
Removing the Jlink_ReqMod,Jlink_AddMLimitM,Jlink_GenOpt:
test TESTLIST=Jlink_ReqMod_0,Jlink_ReqMod_1,Jlink_AddMLimitM_0,Jlink_AddMLimitM_1,Jlink_GenOpt_0,Jlink_GenOpt_1
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48587/console
special.system
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48552/
extended.system
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48406/
sanity.system
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/48446/

@annaibm annaibm marked this pull request as ready for review March 5, 2025 16:41
@smlambert
Copy link
Contributor

hi @annaibm - can you reference the issue that this is addressing so that other committers will have more context and understand what this PR is about? (Believe its about moving jlink tests out of system group)

@annaibm
Copy link
Contributor Author

annaibm commented Mar 5, 2025

hi @annaibm - can you reference the issue that this is addressing so that other committers will have more context and understand what this PR is about? (Believe its about moving jlink tests out of system group)

Hi @ShelleyLambert, I have added the issue reference in #5992 (comment). Let me know if any further details are needed. Thanks!

@smlambert
Copy link
Contributor

Hi @ShelleyLambert, I have added the issue reference in #5992 (comment). Let me know if any further details are needed.

thanks @annaibm !

llxia
llxia approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from pshipton March 5, 2025 19:29
@pshipton pshipton merged commit c7ec790 into adoptium:master Mar 6, 2025
3 checks passed
@llxia llxia mentioned this pull request Mar 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annaibm @smlambert @pshipton @llxia