-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk: add jdk tier1 cipher tests #5971
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2635,6 +2635,35 @@ | |
<feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:nonapplicable</feature> | ||
</features> | ||
</test> | ||
<test> | ||
<testCaseName>jdk11_tier1_cipher</testCaseName> | ||
<command>$(JAVA_COMMAND) -Xmx512m -jar $(Q)$(TEST_RESROOT)$(D)jtreg$(D)lib$(D)jtreg.jar$(Q) \ | ||
$(JTREG_BASIC_OPTIONS) $(JDK_NATIVE_OPTIONS) -vmoptions:$(Q)-Xmx512m $(JVM_OPTIONS) $(VMOPTION_HEADLESS)$(Q) \ | ||
$(TIMEOUT_HANDLER) \ | ||
-w $(Q)$(REPORTDIR)$(D)work$(Q) \ | ||
-r $(Q)$(REPORTDIR)$(D)report$(Q) \ | ||
-jdk:$(Q)$(TEST_JDK_HOME)$(Q) \ | ||
-exclude:$(Q)$(JTREG_JDK_TEST_DIR)$(D)ProblemList.txt$(Q) \ | ||
-exclude:$(Q)$(TEST_RESROOT)$(D)$(PROBLEM_LIST_FILE)$(Q) \ | ||
${FEATURE_PROBLEM_LIST_FILE} \ | ||
${VENDOR_PROBLEM_LIST_FILE} \ | ||
$(Q)$(JTREG_JDK_TEST_DIR)/com/sun/crypto/provider/Cipher$(Q); \ | ||
$(TEST_STATUS)</command> | ||
<versions> | ||
<version>11+</version> | ||
</versions> | ||
<levels> | ||
<level>sanity</level> | ||
</levels> | ||
<groups> | ||
<group>openjdk</group> | ||
</groups> | ||
<features> | ||
<feature>FIPS140_2:nonapplicable</feature> | ||
<feature>FIPS140_3_OpenJCEPlusFIPS:nonapplicable</feature> | ||
<feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:nonapplicable</feature> | ||
Comment on lines
+2662
to
+2664
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jasonkatonica should we run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be honest, I don't really know implications of this in testing (and how to test it works with FIPS on adoptium infra?). Maybe it could make sense to also run this in FIPS. (I just kept features section there as it was in other related target, I based this on. ) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HI @llxia Yes in general the tests in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @jasonkatonica . Yes, we are already running these tests. |
||
</features> | ||
</test> | ||
<test> | ||
<testCaseName>jdk_vector</testCaseName> | ||
<disables> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test runs for JDK11+. Please remove
jdk11
from testCaseName. To align with other test name, we should call itjdk_cipher
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this name to be consistent with related targets
jdk11_tier1_buffer
,jdk11_tier1_iso8859
,jdk11_tier1_pack200
(above new one in playlist). Only pack200 is 11 other ones are 11+. (Non of these have name inTEST.groups
in openjdk.)