openjdk: add jdk tier1 cipher tests #5971
Conversation
| @@ -2635,6 +2635,35 @@ | |||
| <feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:nonapplicable</feature> | |||
| </features> | |||
| </test> | |||
| <test> | |||
| <testCaseName>jdk11_tier1_cipher</testCaseName> | |||
There was a problem hiding this comment.
This test runs for JDK11+. Please remove jdk11 from testCaseName. To align with other test name, we should call it jdk_cipher.
There was a problem hiding this comment.
I used this name to be consistent with related targets jdk11_tier1_buffer, jdk11_tier1_iso8859, jdk11_tier1_pack200 (above new one in playlist). Only pack200 is 11 other ones are 11+. (Non of these have name in TEST.groups in openjdk.)
| <feature>FIPS140_2:nonapplicable</feature> | ||
| <feature>FIPS140_3_OpenJCEPlusFIPS:nonapplicable</feature> | ||
| <feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:nonapplicable</feature> |
There was a problem hiding this comment.
@jasonkatonica should we run com/sun/crypto/provider/Cipher with the FIPS profile?
There was a problem hiding this comment.
To be honest, I don't really know implications of this in testing (and how to test it works with FIPS on adoptium infra?). Maybe it could make sense to also run this in FIPS. (I just kept features section there as it was in other related target, I based this on. )
There was a problem hiding this comment.
HI @llxia Yes in general the tests in the com/sun/crypto/provider/Cipher directory are crypto related tests that should be run in the various FIPS modes. We have some of them on our exclusion list so I assume we are typically running these. I still think we want to run what we can in the FIPS test buckets that are crypto related.
There was a problem hiding this comment.
Thanks @jasonkatonica . Yes, we are already running these tests.
There was a problem hiding this comment.
com/sun/crypto/provider/Cipher is included in jdk_security2. They are running in sanity.openjdk. I do not think we should have a duplicate test target for com/sun/crypto/provider/Cipher and run it twice.
https://ci.adoptium.net/job/Test_openjdk11_hs_sanity.openjdk_aarch64_mac/273/testReport/
Fair point, sorry, I have not realized sanity already runs them as part of |
|
I'll then close this PR, sorry for noise. |
This adds tier1 cipher tests present in jdk11+. Similar targets already exists for buffer, iso8859 and pack200 tests. Goal is, that sanity level includes all tests from tier1.
Testing:
jdk11:
linux-x86_64-jdk11: OK
linux-x86_64-jdk11-openj9: OK
linux-arm-jdk11: OK
linux-s390x-jdk11: OK
mac-x86_64-jdk11: OK
aix-ppc64-jdk11: OK
jdk17:
linux-aarch64-jdk17: OK
jdk21:
linux-aarch64-jdk21: OK