Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jdk22u mirror repository #52

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

sxa
Copy link
Member

@sxa sxa commented Apr 5, 2024

Upstream jdk22 development has moved for jdk22u, so we need to be able to mirror that one to build the release later this month.

Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa requested a review from a team as a code owner April 5, 2024 09:33
Copy link

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

Copy link

This is your friendly self-service bot.

The author (sxa) of this PR is associated with this organization in the role of MEMBER.

Additionally, sxa is a member of the following teams:

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@@ -580,6 +580,7 @@ orgs.newOrg('adoptium') {
},
newMirrorRepo('jdk21u') {},
newMirrorRepo('jdk22') {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to archive this one too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was asking that question in slack too as it's not yet in the docs to do so :-) Worst case I was going to do it as a separate PR but happy to updte this one for that now.

This comment has been minimized.

1 similar comment

This comment has been minimized.

Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 65c66c5
Organization adoptium[id=adoptium]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="jdk22"] {
!     archived                          = false -> true
!   }

+  add repository[name="jdk22u"] {
+    allow_auto_merge                  = false
+    allow_forking                     = true
+    allow_merge_commit                = true
+    allow_rebase_merge                = true
+    allow_squash_merge                = true
+    allow_update_branch               = false
+    archived                          = false
+    default_branch                    = "master"
+    delete_branch_on_merge            = false
+    dependabot_alerts_enabled         = false
+    dependabot_security_updates_enabled = false
+    description                       = "This repo is an unmodified mirror of source code obtained from OpenJDK. It has been and may still be used to create builds that are untested and incompatible with the Java SE specification. You should not deploy or write to this code, but instead use the tested and certified Java SE compatible version that is available at https://adoptium.net."
+    gh_pages_build_type               = "disabled"
+    has_discussions                   = false
+    has_issues                        = false
+    has_projects                      = false
+    has_wiki                          = false
+    homepage                          = "https://adoptium.net"
+    is_template                       = false
+    merge_commit_message              = "PR_TITLE"
+    merge_commit_title                = "MERGE_MESSAGE"
+    name                              = "jdk22u"
+    private                           = false
+    private_vulnerability_reporting_enabled = true
+    secret_scanning                   = "disabled"
+    secret_scanning_push_protection   = "disabled"
+    squash_merge_commit_message       = "COMMIT_MESSAGES"
+    squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+    template_repository               = null
+    topics                            = []
+    web_commit_signoff_required       = false
+  }

+  add repo_workflow_settings[repository="jdk22u"] {
+    enabled                           = false
+  }
  
  Plan: 2 to add, 1 to change, 0 to delete.

This comment has been minimized.

Copy link

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

This comment has been minimized.

Copy link

This is your friendly self-service bot.
This Pull Request is eligible for auto-merging as it passed the following checks:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource

In order to automatically merge and apply the changes, add a comment /otterdog merge. 🚀

@netomi
Copy link
Contributor

netomi commented Apr 5, 2024

ok so we need to reduce the noise for automated comments, but it looks good to merge yourself. Will make the necessary adjustments in PMI after merging.

@gdams
Copy link
Member

gdams commented Apr 5, 2024

@sxa looks like you can automerge now

@sxa
Copy link
Member Author

sxa commented Apr 5, 2024

/otterdog merge

@eclipse-otterdog eclipse-otterdog bot merged commit 4e9e6bd into adoptium:main Apr 5, 2024
3 checks passed
Copy link

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization adoptium[id=adoptium]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="jdk22"] {
!     archived                          = false -> true
!   }

+  add repository[name="jdk22u"] {
+    allow_auto_merge                  = false
+    allow_forking                     = true
+    allow_merge_commit                = true
+    allow_rebase_merge                = true
+    allow_squash_merge                = true
+    allow_update_branch               = false
+    archived                          = false
+    default_branch                    = "master"
+    delete_branch_on_merge            = false
+    dependabot_alerts_enabled         = false
+    dependabot_security_updates_enabled = false
+    description                       = "This repo is an unmodified mirror of source code obtained from OpenJDK. It has been and may still be used to create builds that are untested and incompatible with the Java SE specification. You should not deploy or write to this code, but instead use the tested and certified Java SE compatible version that is available at https://adoptium.net."
+    gh_pages_build_type               = "disabled"
+    has_discussions                   = false
+    has_issues                        = false
+    has_projects                      = false
+    has_wiki                          = false
+    homepage                          = "https://adoptium.net"
+    is_template                       = false
+    merge_commit_message              = "PR_TITLE"
+    merge_commit_title                = "MERGE_MESSAGE"
+    name                              = "jdk22u"
+    private                           = false
+    private_vulnerability_reporting_enabled = true
+    secret_scanning                   = "disabled"
+    secret_scanning_push_protection   = "disabled"
+    squash_merge_commit_message       = "COMMIT_MESSAGES"
+    squash_merge_commit_title         = "COMMIT_OR_PR_TITLE"
+    template_repository               = null
+    topics                            = []
+    web_commit_signoff_required       = false
+  }

+  add repo_workflow_settings[repository="jdk22u"] {
+    enabled                           = false
+  }

  
  Applying changes:


  Done.
  
  Executed plan: 2 added, 1 changed, 0 deleted.

@sxa
Copy link
Member Author

sxa commented Apr 5, 2024

ok so we need to reduce the noise for automated comments, but it looks good to merge yourself. Will make the necessary adjustments in PMI after merging.

Yeah it is definitely quite talkative just now ;-)

@netomi
Copy link
Contributor

netomi commented Apr 5, 2024

PMI has been updated.

@sxa
Copy link
Member Author

sxa commented Apr 5, 2024

@netomi Is there any delay in the setup of new repositories - I'm getting ERROR: Permission to adoptium/jdk22u.git denied to sxa when I try to issue a push to https://github.com/adoptium/jdk22u

@netomi
Copy link
Contributor

netomi commented Apr 5, 2024

so it can take up to 3h for the permissions to be setup correctly. I did it now manually, should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants