Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation in 1.13.8 #66

Closed
mike-post opened this issue Aug 13, 2015 · 5 comments · Fixed by #67
Closed

Deprecation in 1.13.8 #66

mike-post opened this issue Aug 13, 2015 · 5 comments · Fixed by #67

Comments

@mike-post
Copy link

I just upgraded to ember 1.13.8 and I'm seeing the following deprecation notice from emberx-select:

DEPRECATION: A property of <crawler-ui@view:-outlet::ember453> was modified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation.
        at _emberViewsViewsCore_view.default.extend.scheduleRevalidate (http://localhost:4200/crawler/assets/vendor.js:60027:34)
        at http://localhost:4200/crawler/assets/vendor.js:22220:32
        at Object.Stream.notifySubscribers (http://localhost:4200/crawler/assets/vendor.js:31572:11)
        at Object.Stream.notifyExcept (http://localhost:4200/crawler/assets/vendor.js:31512:14)
        at Object.Stream.notify (http://localhost:4200/crawler/assets/vendor.js:31506:12)
        at Object.apply (http://localhost:4200/crawler/assets/vendor.js:32915:18)
        at Object.sendEvent (http://localhost:4200/crawler/assets/vendor.js:26465:28)
        at notifyObservers (http://localhost:4200/crawler/assets/vendor.js:30002:25)
        at propertyDidChange (http://localhost:4200/crawler/assets/vendor.js:29798:5)

I'm getting one deprecation notice for each option tag in the select. My template is:

  {{#x-select value=daysFilter action="filterByDate"}}
    {{#each daysList as |day|}}
      {{#x-option value=day.value}}{{day.text}}{{/x-option}}
    {{/each}}
    {{#x-option value='custom' class=(if isStandardDate 'is-hidden')}}Custom range{{/x-option}}
  {{/x-select}}

I'm using the head of master, as recommended. I even tried rm -rf node_modules ; npm cache clean ; npm install to verify I was REALLY getting the latest, but no luck.

My package.son has "emberx-select": "thefrontside/emberx-select",

@nruth
Copy link

nruth commented Aug 13, 2015

I'm seeing the same thing

@Robdel12
Copy link
Collaborator

Interesting. I'll try to take a look tonight. If not first thing tomorrow

@XpycT
Copy link

XpycT commented Aug 14, 2015

same thing, and

Ember Inspector (Deprecation Trace): Depending on arrays using a dependent key ending with @each is deprecated. Please refactor from Ember.observer('content.@each', function() {}); to Ember.computed('content.[]', function() {}).

Robdel12 added a commit that referenced this issue Aug 14, 2015
This fixes #66. I ended up having to move the way we register x-option
with it's parent component into an ember after render run loop.
@Robdel12
Copy link
Collaborator

Sorry about that! We should be depreciation free now.

@mike-post
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants