[WIP] use the new store.isFragment method

[GavinJoyce]

We are currently relying on store.createFragment raising an exception to detect if a model is a factory. This exception comes from an assertion which will be stripped in certain builds once ember-cli/rfcs#50 is adopted.

I recently added a store.isFragment method to ember-data-model-fragments. This hasn't yet been released, but when it is it would be nice to start using it.

TODO:

• Update the added in 'ember-data-model-fragments' v2.3.x comment once it has been released

[danielspaniel]

This is pretty great Gavin.
Should have thought to do this myself because the other day I was looking at that method and was not loving it because the try catch was swallowing an exception ( mistake I was making ) in my test ( which made it hard / nearly impossible to detect ).
I did not think to add what you did ( a nice method in the fragment addon ) .. so 'heck yeah' to this.
Let me know as soon as that new version is ready.

[GavinJoyce]

@danielspaniel ember-data-model-fragments 2.11.0 has been released so I think this is ready to go now

[danielspaniel]

How should I handle this for people who have not updated to 2.11 fragments.
I saw the thread in the fragments PR and yes, I should have used Fragment.detect, I just did not know about that method.
What I am thinking is that I could just copy what you are doing is that method

  let type = store.modelFor(modelName);
  Fragment.detect(type); 

rather than use the method store.isFragment since then people are forced to update to 2.11 fragments .. know what I mean. Thoughts?

[GavinJoyce]

Thanks sounds fine @danielspaniel, feel free to close this PR if you go down that route

[danielspaniel]

I will close this then @GavinJoyce , because I converted that method to use your code from that method and it works fine now. Much better .. so thanks again.

[danielspaniel]

Release:
https://github.com/danielspaniel/ember-data-factory-guy/releases/tag/v2.10.1
has the better implemented fragment checker ( copied from you )