[BUGFIX] Replace private and deprecated _lookupFactory with public & performant factoryFor

[cibernox]

No API surface has changed. _factoryFor will be removed in 2.13.

[offirgolan]

@cibernox thank you for this. Can you move the code to a util file? Something like:

// addon/utils/lookup-class.js
export default function lookupClass(owner, type) {
  let klass;
  if (owner.factoryFor) {
        let maybeKlass = owner.factoryFor(type);
        klass = maybeErrorMessages && maybeErrorMessages.class;
      } else {
        klass = owner._lookupFactory(type);
      }
return klass;
}

[cibernox]

sure

[offirgolan]

@cibernox thanks! Also, is there a need to fallback to _lookupFactory? Shouldnt the getOwner polyfill take care of that?

[cibernox]

@offirgolan It is needed. getOwner gives you an applicationInstance, but ApplicationInstance#factoryFor was added in 2.12.

[cibernox]

@offirgolan I added it in -private, because it's for internal usage only.

[offirgolan]

@cibernox released with v3.2.2. Thanks again for the help 😸