Introduce ignoreWhitespace in presence validator

[krasnoukhov]

This allows using a validator for a case when value should not consist only of space(s).

[aaronbhansen]

I feel like this should be a configuration option for the presence validator. Something like

validator('presence', { ignoreWhitespace: true })

or

validator('presence', { ignoreBlank: true })

Since this would change existing functionality for people already using it today.

[krasnoukhov]

Makes sense, thanks. I've updated the commit. CI is failing though, but it does not look like my change broke it, so not sure what can I do

[krasnoukhov]

CI is green now!

[offirgolan]

@krasnoukhov thank you for this feature! I think I prefer "ignoreWhitespace" more just because it's a little more intuitive, but I'm not sure if that's more misleading than ignoreBlank. May I ask why you chose ignoreBlank? Besides that, if you can just add the option details in the docs (see addon/validators/format), I believe I can just go ahead and merge this baby 😸

[krasnoukhov]

@offirgolan No problem! Well ignoreBlank is just shorter, but I've updated a commit with a new name and polished doc.

[offirgolan]

Oh okay I was just curious. After some thought, I believe ignoreWhitespace
sort of implies that it will ignore all whitspace characters in a string.
Maybe ignoreBlank was the better choice but regardless, I can always make
that change after I merge 😊. I'm currently on vacation so I'll merge this
along with some open PRs early next week and issue a release.

On Thursday, April 21, 2016, Dmitry Krasnoukhov [email protected]
wrote:

@offirgolan https://github.com/offirgolan No problem! Well ignoreBlank
is just shorter, but I've updated a commit with a new name and polished doc.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#173 (comment)

Thanks,
Offir Golan

[krasnoukhov]

Sure, I don't mind at all, maybe you'll think of even better name for that! Thanks and have a good rest of the week.

[blimmer]

LGTM