Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember-inflector deprecations #110

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

rmachielse
Copy link
Contributor

Fixes #109

@rmachielse rmachielse force-pushed the fix/inflector branch 2 times, most recently from 7a2959d to 4adda50 Compare November 17, 2017 07:36
@rmachielse
Copy link
Contributor Author

@pangratz I think this is the change we need to fix the ember-inflector deprecations. I added the same version range that ember-data uses, therefore it doesn't cause any changes to yarn.lock. Do you agree it should explicitly depend on it?

Although the tests run fine on the default scenario, the job is failing with this error:

Cannot find module 'bower' from '/home/travis/build/ember-data/active-model-adapter/node_modules/ember-cli/bin'

Do you have any idea what that could be?

@rmachielse rmachielse force-pushed the fix/inflector branch 6 times, most recently from c4a3764 to 81f8d22 Compare November 20, 2017 21:40
@rmachielse
Copy link
Contributor Author

@pangratz the failing tests are related to ember-cli/ember-try#161, I prepended a commit to fix them.

@pangratz
Copy link
Contributor

Sorry for the delay here @rmachielse.

Can you update this PR to use the latest version of ember inflector and add the updated yarn.lock too? Also, once @Turbo87's #113 is merged, we can get rid of the updates to the ember try config and keep this PR updating ember-inflector only.

Thanks!

@Turbo87
Copy link
Contributor

Turbo87 commented Nov 30, 2017

I added the same version range that ember-data uses

@rmachielse ember-data is currently using ^2.0.0 (see https://github.com/emberjs/data/blob/ed4e45f7ca4a28a478293857442164e295eccf5b/package.json#L43)

@rmachielse
Copy link
Contributor Author

@pangratz no problem, will do!

@rmachielse
Copy link
Contributor Author

@pangratz @Turbo87 I have adapted, and tests are ✅

@pangratz
Copy link
Contributor

Thanks @rmachielse for the quick response. This is ready for 🚀

@pangratz pangratz merged commit e4e8d95 into adopted-ember-addons:master Nov 30, 2017
@rmachielse
Copy link
Contributor Author

@pangratz will you cut a release soon?

@pangratz
Copy link
Contributor

This has been released by @bmac in v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants