fix(number-field): negative numbers handled

[blunteshwar]

Description

Number field was not correctly handling negative numbers when step was a floating point number

Related issue(s)

Motivation and context

How has this been tested?

• Test case 1
  1. Go here
  2. Do this
• Test case 2
  1. Go here
  2. Do this

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch Preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Classic | Lightest | Medium | LTR
• Classic | Lightest | Medium | RTL
• Classic | Lightest | Large | LTR
• Classic | Lightest | Large | RTL
• Classic | Light | Medium | LTR
• Classic | Light | Medium | RTL
• Classic | Light | Large | LTR
• Classic | Light | Large | RTL
• Classic | Dark | Medium | LTR
• Classic | Dark | Medium | RTL
• Classic | Dark | Large | LTR
• Classic | Dark | Large | RTL
• Classic | Darkest | Medium | LTR
• Classic | Darkest | Medium | RTL
• Classic | Darkest | Large | LTR
• Classic | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL

[github-actions]

Tachometer results

Chrome

number-field permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	622 kB	227.79ms - 230.98ms	-	unsure 🔍 -1% - +1% -1.31ms - +2.66ms
branch	618 kB	227.52ms - 229.90ms	unsure 🔍 -1% - +1% -2.66ms - +1.31ms	-

slider permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	461 kB	181.42ms - 184.06ms	-	unsure 🔍 -1% - +1% -1.52ms - +1.60ms
branch	457 kB	181.88ms - 183.52ms	unsure 🔍 -1% - +1% -1.60ms - +1.52ms	-

Firefox

number-field permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	622 kB	564.31ms - 602.57ms	-	unsure 🔍 -5% - +4% -29.86ms - +26.18ms
branch	618 kB	564.81ms - 605.75ms	unsure 🔍 -4% - +5% -26.18ms - +29.86ms	-

slider permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	461 kB	447.92ms - 478.04ms	-	unsure 🔍 -9% - +1% -43.90ms - +3.38ms
branch	457 kB	465.02ms - 501.46ms	unsure 🔍 -1% - +10% -3.38ms - +43.90ms	-

[Westbrook]

This looks pretty good to me. If you could add a test to confirm that the original issue is now address this will be good to go!

[Rajdeepc]

@blunteshwar if you are able to add a test we will be able to merge this

[blunteshwar]

@blunteshwar if you are able to add a test we will be able to merge this

done!

[Rajdeepc]

@Westbrook If we are good to go, let's land this 🛩️

[Westbrook]

!