-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tokens): support style-dictionary build in windows env #2500
base: main
Are you sure you want to change the base?
Conversation
File metricsSummaryTotal size: 3.88 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailstokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-2500--spectrum-css.netlify.app |
676fef5
to
2c41fa6
Compare
9548f0f
to
deeeac9
Compare
16f409e
to
c0f9463
Compare
|
098738b
to
dc002cf
Compare
dc002cf
to
ae16d2a
Compare
ae16d2a
to
6cd570b
Compare
dd0694c
to
b565823
Compare
b565823
to
20705b6
Compare
20705b6
to
9164f9f
Compare
9164f9f
to
9880b3a
Compare
cbbffd8
to
e1a3792
Compare
Something to evaluate: https://github.com/storybookjs/storybook/pull/29676/files |
e1a3792
to
6fab03d
Compare
0fc864b
to
38921ac
Compare
a2fe0a5
to
e47aa37
Compare
e47aa37
to
85f0636
Compare
Description
When adding an experimental windows-latest run, I found that the style-dictionary compilation was failing pretty terrifically. This PR aims to fix that by wrapping pathing in path.join so that it can be rendered in a windows-friendly format.
Update the .gitattributes to force windows to use lf instead of crlf so that the generated mods files don't show a diff after the build.
Switch the style-dictionary build to use the vanilla command instead of the nx executor.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
This can be validated via CI which will try to run the tokens build in windows. If the task fails, this PR did not work.
To-do list