Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add isRequired to NumberField RenderProps #7831

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

snowystinger
Copy link
Member

Closes

a definitely correct part of #6151

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 25, 2025

@rspbot
Copy link

rspbot commented Feb 25, 2025

## API Changes

react-aria-components

/react-aria-components:NumberFieldRenderProps

 NumberFieldRenderProps {
   isDisabled: boolean
   isInvalid: boolean
+  isRequired: boolean
   state: NumberFieldState
 }

@yihuiliao yihuiliao added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 3f244b4 Feb 26, 2025
30 checks passed
@yihuiliao yihuiliao deleted the fix-isrequired-for-numberfield branch February 26, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants