Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that class names produced by S2 style macro differs for each theme #7822

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhovhannes
Copy link
Contributor

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

"@layer _.a, _.b;

@layer _.a {
.chc_2c {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chc here is the hash of 0.6.0 read from package.json. I pushed this test just to illustrate how my changes affect produced CSS.

@bhovhannes bhovhannes force-pushed the main-hb-fix-style-macro-theme-clashes branch from 0ab887a to 4ce10e1 Compare February 24, 2025 12:25
@bhovhannes bhovhannes force-pushed the main-hb-fix-style-macro-theme-clashes branch from 4ce10e1 to 8ea8919 Compare February 25, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant