Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: control focus on search behavior #7807

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

romansndlr
Copy link
Contributor

@romansndlr romansndlr commented Feb 21, 2025

Closes #7781

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@romansndlr romansndlr marked this pull request as draft February 21, 2025 11:47
@romansndlr
Copy link
Contributor Author

Hi @LFDanLu @devongovett 👋

I would love for some guidance on what else should I do here to get this PR to a reviewable state

@eyalcohen4
Copy link

We really need this feature in :) Thank you @romansndlr

@romansndlr romansndlr marked this pull request as ready for review February 22, 2025 11:38
@reidbarber
Copy link
Member

Thanks for this! Discussed with the team and we decided that since this defaults to false, we should rename it so it can default to true. I pushed that change and also added a unit test, hope you don't mind! We're hoping to get this in very soon!

@romansndlr
Copy link
Contributor Author

Thanks for this! Discussed with the team and we decided that since this defaults to false, we should rename it so it can default to true. I pushed that change and also added a unit test, hope you don't mind! We're hoping to get this in very soon!

Y'all are amazing! Thanks so much!

@reidbarber
Copy link
Member

@romansndlr No problem! Do you mind signing the CLA, then closing and re-opening this PR? That should trigger a re-build that should pass CI checks.

@devongovett devongovett added this pull request to the merge queue Feb 25, 2025
Merged via the queue into adobe:main with commit ad70785 Feb 25, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt out of auto focus on first ListBoxItem inside AutoComplete
4 participants