chore: remove toast priority queue #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
previously approved these changes
Feb 20, 2025
# Conflicts: # packages/@react-aria/toast/docs/useToast.mdx
reidbarber
previously approved these changes
Feb 21, 2025
This reverts commit 18b4975.
devongovett
approved these changes
Feb 21, 2025
## API Changes
react-aria-components/react-aria-components:ToastOptions ToastOptions {
onClose?: () => void
- priority?: number
timeout?: number
}@react-stately/toast/@react-stately/toast:QueuedToast QueuedToast <T> {
content: T
key: string
onClose?: () => void
- priority?: number
timeout?: number
timer?: Timer
}/@react-stately/toast:ToastOptions ToastOptions {
onClose?: () => void
- priority?: number
timeout?: number
} |
reidbarber
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Discussed in pre-ga meeting, removing as Spectrum doesn't use it anymore and it's not part of Toast aria patterns. We can add it back if enough people request it.
Instead, it's recommended that if people need a priority queue they should subclass or copy the ToastQueue implementation we have and add the priority queue there.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: