-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add autofill stories #7722
Conversation
}}> | ||
<TextField> | ||
<Label>Address</Label> | ||
<Input name="streetAddress" type="text" id="streetAddress" autoComplete="shipping street-address" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, this one renders as autocomplete off for me...
https://reactspectrum.blob.core.windows.net/reactspectrum/df4ad8242241bf9959c9148d20b4be683ab320df/storybook/index.html?path=/story/react-aria-components--form-auto-fill-example&providerSwitcher-express=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh strange. it looks like it has autocomplete=""shipping address-level2" based on the screenshot. does it not autofill for you either?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, node above that one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh my b. that's really weird because it appears for me. it should be valid since i see an example of it in the mdn docs...it might be good to see if another person can reproduce
do you see this in other browsers as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, well, i updated chrome last night. now it's rendering. My Chrome autofill works on it, but my Dashlane doesn't recognize it for some reason still. At this point though, I think it's correct and I'm just running into local issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
To test, you'll need to go to your browser's setting, find "Autofill", and save an address.
🧢 Your Project: