Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: S2 Badge context #7704

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: S2 Badge context #7704

merged 2 commits into from
Feb 5, 2025

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Feb 2, 2025 •
edited
Loading

Closes #7696

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 3, 2025

Build successful! 🎉

@snowystinger snowystinger added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 6c4c57d Feb 5, 2025
30 checks passed
@snowystinger snowystinger deleted the fix-badge-context branch February 5, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nesting objects within a S2 Checkbox which is inside a CheckboxGroup causes React failures
4 participants
@snowystinger @rspbot @reidbarber @yihuiliao