Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve literal search for member expressions #7604

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

nwidynski
Copy link
Contributor

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@nwidynski
Copy link
Contributor Author

nwidynski commented Jan 13, 2025

We adapted this recently and wanted to give back this small improvement 👍
Very unfortunate this hasn't made its way to the official repo, it's a great rule.

PS: I was also wondering whether parentFunction() may be replaced by getScope().block of the definition node. Is there any scenario where the definition would be inside a "non-function" scope while still accessible by the member?

@nwidynski
Copy link
Contributor Author

@devongovett Anything blocking this?

@reidbarber reidbarber added this pull request to the merge queue Feb 3, 2025
Merged via the queue into adobe:main with commit 4322a3e Feb 4, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants