Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update JSDocs and apis for release #7595

Merged
merged 2 commits into from
Jan 10, 2025
Merged

chore: Update JSDocs and apis for release #7595

merged 2 commits into from
Jan 10, 2025

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Jan 10, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Jan 10, 2025

@rspbot
Copy link

rspbot commented Jan 10, 2025

@rspbot
Copy link

rspbot commented Jan 10, 2025

## API Changes

react-aria-components

/react-aria-components:AutocompleteProps

+AutocompleteProps {
+  children: ReactNode
+  defaultInputValue?: string
+  filter?: (string, string) => boolean
+  inputValue?: string
+  onInputChange?: (string) => void
+  slot?: string | null
+}

@react-spectrum/s2

/@react-spectrum/s2:Tabs

 Tabs {
   UNSAFE_className?: string
   UNSAFE_style?: CSSProperties
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   children?: ReactNode
   defaultSelectedKey?: Key
   density?: 'compact' | 'regular' = 'regular'
   disabledKeys?: Iterable<Key>
   id?: string
   isDisabled?: boolean
-  isIconOnly?: boolean
   keyboardActivation?: 'automatic' | 'manual' = 'automatic'
+  labelBehavior?: 'show' | 'hide' = 'show'
   onSelectionChange?: (Key) => void
   orientation?: Orientation = 'horizontal'
   selectedKey?: Key | null
   slot?: string | null
 }

/@react-spectrum/s2:TabsProps

 TabsProps {
   UNSAFE_className?: string
   UNSAFE_style?: CSSProperties
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   children?: ReactNode
   defaultSelectedKey?: Key
   density?: 'compact' | 'regular' = 'regular'
   disabledKeys?: Iterable<Key>
   id?: string
   isDisabled?: boolean
-  isIconOnly?: boolean
   keyboardActivation?: 'automatic' | 'manual' = 'automatic'
+  labelBehavior?: 'show' | 'hide' = 'show'
   onSelectionChange?: (Key) => void
   orientation?: Orientation = 'horizontal'
   selectedKey?: Key | null
   slot?: string | null
 }

@LFDanLu LFDanLu changed the title (chore): Update JSDocs and apis for release chore: Update JSDocs and apis for release Jan 10, 2025
@LFDanLu LFDanLu added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 101d077 Jan 10, 2025
30 of 31 checks passed
@LFDanLu LFDanLu deleted the release_audit branch January 10, 2025 20:02
LFDanLu added a commit that referenced this pull request Jan 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
* Revert "chore: Update JSDocs and apis for release (#7595)"

This reverts commit 101d077.

* Revert "fix: Tabs infinite loop (#7487)"

This reverts commit 8228e4e.

* Revert "fix: Tabs from testing (#7463)"

This reverts commit 494e01c.

* Revert "feat: Tabs collapse behaviour (#7202)"

This reverts commit cd4da2b.

* add stuff back that we still want

* update lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants