fix: S2 examples Popover and add CustomDialog #7459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from testing
Changes:
Possible Bug: If we don't define
size
on CustomDialog it takes the full screen width.✅ Pull Request Checklist:
📝 Test Instructions:
For the Popover and CustomDialog dialog changes those can be tested on desktop.
For the parcel example app please test on mobile for the viewport and ButtonGroup changes. The viewport test is pickers open below the trigger.
When testing the webpack app, is there a ResizeObserver error on scroll down? I thought it was related to the ButtonGroup change, but I removed the change and it persisted. I'm hoping it's a local build issue. That's the only change in that file and I wouldn't expect changes to Lazy.jsx to impact this.
Speaking of local build issue, my parcel build is refusing to import Popover and CustomDialog. I'm assuming it's a local issue and no one else will see it.
🧢 Your Project:
RSP