fix boxing/unboxing

packages/core/src/core/schema/core/debugging.ts

@@ -11,4 +11,4 @@ governing permissions and limitations under the License.
 */
 
 // turn this on to capture stack traces into schemas and template objects.
-export const DEBUG = false;
+export const DEBUG = true;

packages/core/src/core/schema/definition/datum.ts

@@ -302,7 +302,7 @@ function defineScalar<T extends Scalar>(self: DatumRepresentation): Schema<T> {
       }
 
       if (appraised !== undefined) {
-        appraised = convertScalar(appraised, type) as T;
+        appraised = convertScalar(appraised, type, { unboxed }) as T;
       }
 
       if (appraised === undefined && context.mode === "match") {
@@ -454,7 +454,7 @@ function resolveScalar<T extends Scalar>(
       throw diagnostic(context, `define: ${issue}`);
     }
 
-    return convertScalar(result, self.type) as T;
+    return convertScalar(result, self.type, { unboxed }) as T;
   }
 }
 
@@ -478,14 +478,15 @@ async function doRenderScalar<T>(
   // if there's a pattern which is already defined, we can evaluate it
   const definition = resolveDefinedPattern(context, configuredPatterns);
   if (definition !== undefined) {
-    result = convertScalar(definition, type);
+    result = convertScalar(definition, type, { unboxed });
   }
 
   if (mode === "render" || mode === "prerender" || mode === "postrender") {
     if (result === undefined) {
       result = convertScalar(
         (await evaluateScalar(context, configuredPatterns)) as Scalar,
         type,
+        { unboxed },
       );
     }
 

packages/core/src/core/schema/definition/scalar.ts

@@ -32,7 +32,7 @@ export type ScalarType = "string" | "number" | "boolean" | "bigint" | "null";
 export function convertScalar(
   value?: Scalar | unknown,
   type?: ScalarType,
-  anull?: boolean,
+  { anull, unboxed }: { anull?: boolean; unboxed?: boolean } = {},
 ): Scalar | unknown {
   if (value === undefined) {
     return anull ? null : undefined;
@@ -52,7 +52,7 @@ export function convertScalar(
         return createNumber(value["source"]);
       }
 
-      return createNumber(String(value));
+      return unboxed ? Number(value) : createNumber(String(value));
     case "string":
       return String(value);
     case "bigint":
@@ -64,7 +64,11 @@ export function convertScalar(
         return value;
       }
 
-      return value !== undefined ? createBigInt(String(value)) : undefined;
+      return value !== undefined
+        ? unboxed
+          ? BigInt(String(value))
+          : createBigInt(String(value))
+        : undefined;
     default:
       return value;
   }
@@ -113,11 +117,15 @@ export function createNumber(source: string, value?: number) {
   const numberObject = Object.assign(new Number(value ?? source), { source });
 
   if (DEBUG) {
+    const created = new Error("created-at");
     Object.defineProperty(numberObject, "valueOf", {
       value() {
         return Number(value ?? source);
       },
     });
+    Object.defineProperty(numberObject, "created", {
+      value: created,
+    });
   }
 
   Object.defineProperty(numberObject, "toString", {

packages/core/src/core/schema/definition/structures/reference.ts

@@ -355,7 +355,7 @@ export function defineReference<T = unknown>(
         // if the schema was a stub, we'll try to derive the value
         // by evaluating the refs.
         if (result !== undefined) {
-          return convertScalar(result, encoding, anull) as T;
+          return convertScalar(result, encoding, { anull }) as T;
         }
       }
 
@@ -368,7 +368,7 @@ export function defineReference<T = unknown>(
 
         defineReferenceValue(context, value);
 
-        return convertScalar(value, encoding, anull) as T;
+        return convertScalar(value, encoding, { anull }) as T;
       }
 
       return anull ? (null as T) : undefined!;