Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

137 create an html diff report #139

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Jun 20, 2024

Description

Related Issue

Fixes #137

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@baubakg baubakg linked an issue Jun 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (14a1688) to head (04b642e).

Files Patch % Lines
.../campaign/tests/logparser/core/LogDataFactory.java 97.33% 0 Missing and 2 partials ⚠️
...aign/tests/logparser/utils/LogParserFileUtils.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #139      +/-   ##
============================================
+ Coverage     95.28%   95.79%   +0.50%     
- Complexity      258      270      +12     
============================================
  Files            17       18       +1     
  Lines           636      713      +77     
  Branches        101       99       -2     
============================================
+ Hits            606      683      +77     
+ Misses           19       17       -2     
- Partials         11       13       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@baubakg baubakg merged commit 33abacd into main Jun 21, 2024
9 of 10 checks passed
@baubakg baubakg deleted the 137-create-an-html-diff-report branch June 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an HTML Diff Report
1 participant