fix(data): keep runtime for data-embed and fix tests

adobe · Apr 21, 2021 · 41b9276 · 41b9276
1 parent 51f3cae
commit 41b9276
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 16 deletions.
diff --git a/docs/action-properties-secrets.md b/docs/action-properties-secrets.md
@@ -171,7 +171,7 @@ URL of an Embed Service that takes the appended URL and returns an embeddable HT
 The default value is:
 
 ```json
-"https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1"
+"https://helix-pages.anywhere.run/helix-services/embed@v1"
 ```
 
 ## DATA_EMBED_SERVICE
@@ -197,7 +197,7 @@ URL of a DataEmbed Service that takes the appended URL and returns an iterable J
 The default value is:
 
 ```json
-"https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v1"
+"https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v2"
 ```
 
 ## EMBED_SELECTOR

diff --git a/docs/secrets-properties-data_embed_service.md b/docs/secrets-properties-data_embed_service.md
@@ -19,5 +19,5 @@ URL of a DataEmbed Service that takes the appended URL and returns an iterable J
 The default value is:
 
 ```json
-"https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v1"
+"https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v2"
 ```
diff --git a/docs/secrets-properties-embed_service.md b/docs/secrets-properties-embed_service.md
@@ -19,5 +19,5 @@ URL of an Embed Service that takes the appended URL and returns an embeddable HT
 The default value is:
 
 ```json
-"https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1"
+"https://helix-pages.anywhere.run/helix-services/embed@v1"
 ```
diff --git a/docs/secrets.md b/docs/secrets.md
@@ -171,7 +171,7 @@ URL of an Embed Service that takes the appended URL and returns an embeddable HT
 The default value is:
 
 ```json
-"https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1"
+"https://helix-pages.anywhere.run/helix-services/embed@v1"
 ```
 
 ## DATA_EMBED_SERVICE
@@ -197,7 +197,7 @@ URL of a DataEmbed Service that takes the appended URL and returns an iterable J
 The default value is:
 
 ```json
-"https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v1"
+"https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v2"
 ```
 
 ## EMBED_SELECTOR

diff --git a/docs/secrets.schema.json b/docs/secrets.schema.json
diff --git a/src/schemas/secrets.schema.json b/src/schemas/secrets.schema.json
@@ -53,7 +53,7 @@
     "DATA_EMBED_SERVICE": {
       "type": "string",
       "description": "URL of a DataEmbed Service that takes the appended URL and returns an iterable JSON representation.",
-      "default": "https://helix-pages.anywhere.run/helix-services/data-embed@v2"
+      "default": "https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v2"
     },
     "EMBED_SELECTOR": {
       "type": "string",

diff --git a/test/fixtures/embeds.html b/test/fixtures/embeds.html
@@ -3,7 +3,7 @@ <h1 id="hello-world">Hello “World”</h1>
   <h2 id="gatsby-style-embeds">Gatsby-Style-Embeds</h2>
   <p>
     <esi:include
-      src="https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.youtube.com/embed/2Xc9gXyf2G4">
+      src="https://helix-pages.anywhere.run/helix-services/embed@v1/https://www.youtube.com/embed/2Xc9gXyf2G4">
     </esi:include>
     <esi:remove><code>video: https://www.youtube.com/embed/2Xc9gXyf2G4</code></esi:remove>
   </p>
@@ -12,7 +12,7 @@ <h2 id="gatsby-style-embeds">Gatsby-Style-Embeds</h2>
   <p><code>video: http foo bar</code> looks interesting, but doesn’t work either.</p>
   <h2 id="link--image-style-embeds">Link + Image-Style Embeds</h2>
   <esi:include
-    src="https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.youtube.com/watch?v=KOxbO0EI4MA">
+    src="https://helix-pages.anywhere.run/helix-services/embed@v1/https://www.youtube.com/watch?v=KOxbO0EI4MA">
   </esi:include>
   <esi:remove>
     <p><a href="https://www.youtube.com/watch?v=KOxbO0EI4MA" title="Audi R8"><img
@@ -22,7 +22,7 @@ <h2 id="link--image-style-embeds">Link + Image-Style Embeds</h2>
     <img src="http://img.youtube.com/vi/KOxbO0EI4MA/0.jpg" alt="Audi R8">is just an image.</p>
   <h2 id="image-style-embeds">Image-Style Embeds</h2>
   <esi:include
-    src="https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.youtube.com/watch?v=KOxbO0EI4MA">
+    src="https://helix-pages.anywhere.run/helix-services/embed@v1/https://www.youtube.com/watch?v=KOxbO0EI4MA">
   </esi:include>
   <esi:remove>
     <p><img src="https://www.youtube.com/watch?v=KOxbO0EI4MA" alt=""></p>
@@ -37,7 +37,7 @@ <h2 id="image-style-embeds">Image-Style Embeds</h2>
   <p>is on a paragraph of its own.</p>
   <h2 id="ia-writer-style-embeds">IA Writer-Style Embeds</h2>
   <esi:include
-    src="https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.youtube.com/watch?v=KOxbO0EI4MA">
+    src="https://helix-pages.anywhere.run/helix-services/embed@v1/https://www.youtube.com/watch?v=KOxbO0EI4MA">
   </esi:include>
   <esi:remove>
     <p><a href="https://www.youtube.com/watch?v=KOxbO0EI4MA">https://www.youtube.com/watch?v=KOxbO0EI4MA</a></p>

diff --git a/test/testDataEmbeds.js b/test/testDataEmbeds.js
@@ -547,7 +547,7 @@ describe('Integration Test with Data Embeds (version locked)', () => {
 
     action.versionLock = new VersionLock({
       __ow_headers: {
-        'x-ow-version-lock': 'data-embed=data-embed@v1.2.3',
+        'x-ow-version-lock': 'data-embed=v1.2.3',
       },
     });
     action.downloader = new Downloader(context, action, { forceHttp1: true });

diff --git a/test/testEmbedHandler.js b/test/testEmbedHandler.js
@@ -86,7 +86,7 @@ describe('Test Embed Handler', () => {
     await coerce(action);
 
     embed(action.secrets)((_, tagname, parameters, children) => {
-      assert.equal(parameters.src, 'https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.example.com/');
+      assert.equal(parameters.src, 'https://helix-pages.anywhere.run/helix-services/embed@v1/https://www.example.com/');
       assert.equal(children, undefined);
       assert.equal(tagname, 'esi:include');
     }, node);

diff --git a/test/testPipeWithMarkupConfig.js b/test/testPipeWithMarkupConfig.js
@@ -240,13 +240,13 @@ https://soundcloud.com/mariamamermounib/el-ghasala?in=mariamamermounib/sets/mari
       `<hr>
       <p>from github.</p>
       <pre class="zupp" data-embed="https://www.youtube.com/watch?v=dQw4w9WgXcQ">
-        <esi:include src="https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.youtube.com/watch?v=dQw4w9WgXcQ" class="bar" baz="qux"></esi:include>
+        <esi:include src="https://helix-pages.anywhere.run/helix-services/embed@v1/https://www.youtube.com/watch?v=dQw4w9WgXcQ" class="bar" baz="qux"></esi:include>
         <esi:remove class="bar" baz="qux">
           <p><a href="https://www.youtube.com/watch?v=dQw4w9WgXcQ">https://www.youtube.com/watch?v=dQw4w9WgXcQ</a></p>
         </esi:remove>
       </pre>
       <p>And here is something from Soundcloud</p>
-      <esi:include src="https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://soundcloud.com/mariamamermounib/el-ghasala?in=mariamamermounib/sets/mariam-amer-mounib-amel-eh-fe" onerror="fail"></esi:include>
+      <esi:include src="https://helix-pages.anywhere.run/helix-services/embed@v1/https://soundcloud.com/mariamamermounib/el-ghasala?in=mariamamermounib/sets/mariam-amer-mounib-amel-eh-fe" onerror="fail"></esi:include>
       <esi:remove onerror="fail"><p><a href="https://soundcloud.com/mariamamermounib/el-ghasala?in=mariamamermounib/sets/mariam-amer-mounib-amel-eh-fe">https://soundcloud.com/mariamamermounib/el-ghasala?in=mariamamermounib/sets/mariam-amer-mounib-amel-eh-fe</a></p></esi:remove>`);
   });