Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DINT-1688: Add EDS storefront template option #171

Merged
merged 1 commit into from
Oct 14, 2024
Merged

DINT-1688: Add EDS storefront template option #171

merged 1 commit into from
Oct 14, 2024

Conversation

NadiyaS
Copy link
Contributor

@NadiyaS NadiyaS commented Oct 11, 2024

Description

https://jira.corp.adobe.com/browse/DINT-1688
As Franklin was renamed to EDS, we need to add this name in commerce-events as well. 

Franklin cannot be removed from option due to BIC

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@NadiyaS NadiyaS merged commit 6060ce5 into main Oct 14, 2024
4 checks passed
@NadiyaS NadiyaS deleted the DINT-1688 branch October 14, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants