Simple Themes usability tweaks #9069
Conversation
Not clickable yet, since the workflows get a little tricky (does it appear over top of Themes dialog? does dropdown update when you come back? what if Extension Manager triggers a restart? etc.)
* Show message in Extension Manager about how to switch themes * Link <label>s in Themes dialog to their corresponding controls * Eliminate big blank space at bottom of Themes dialog
…s-help * origin/master: (56 commits) remove selection arrow fix fullpath check when deleting file Fix: toggling Extension Manager long/short description would always show the string for the installed version of an extension (if installed), even when looking at the Available tab. Use info from the current view-model rather than making absolute references to ExtensionManager's model. Fix CSSUtils to work better with vendor-prefixed properties Added unit tests Updated by ALF automation. Added unit test Use unary operator to sort out invalid numbers Use a more strict RegExp Updated by ALF automation. - Move UI code out of ExtensionManagerView into ExtensionManager - Properly escape extension description after toggling truncated part Update CodeMirror to the latest. fix 2 issues after merge Updated by ALF automation. Fix QuickView popover being in the wrong pane remove extra cruft update getting started screen for ja Update strings.js target ja/getting started folder update getting started for FR, add JA ... Conflicts: src/styles/brackets.less
|
@peterflynn I am working through this one right now. There's not a clear path to victory, so it's taking a bit longer than anticipated. Should be done this afternoon though. |
|
@peterflynn Code is ready for you to take a look. I refactored a few things... It wasn't as straight forward as I thought it was going to be. |
|
@peterflynn I have made the settings in the dialog take effect as they are changed... They are reverted when canceling out of the dialog. |
… theme manager. theme settings just reads all available themes directly from theme manager instead.
…g... More like reverting.
|
@peterflynn I got carried away and refactored a few more things in themes... I didn't realize there were that many lose ends or things that just needed TLC. For sure let me know if you got questions. cc @dangoor |
…only want to set the current theme when a new one is installed
|
@peterflynn Do we want to move the review only tag? |
|
@peterflynn @dangoor Is there anything I need to do to move this one forward? |
|
@MiguelCastillo Sorry about the delay! Kevin and I are both away at a conference until Thursday, but hopefully after that we'll be able to take a look shortly after that. |
peterflynn
changed the title
conflicts in theme manager and in brackets.less
… was causing issue where I couldn't remove ThemeManager from ExtensionManager
…to a property of the installInfo rather then part of the updateStatus message
|
@peterflynn @dangoor I did some refactoring in Themes to decouple it from the ExtensionManager module. I had coupled it because I didn't know better. I also resolved a circular reference issue with ThemeSettings and ViewCommandHandlers... It was causing issue when I tried to remove ThemeManager from ExtensionManager. There were other refactorings to cleanup the themes code. I am going to add a unit test for verify that installing a theme will cause that theme to become the current theme. Here is the flow when installing a theme occurs: |
|
@MiguelCastillo You've got some merge conflicts in ExtensionManager.js to resolve. |
|
@peterflynn @dangoor This PR has some good code cleanup I have done for themes code... I make the code more maintainable and decouples themes code from the extension manager code. Can we please get this one a bump in priority? |
|
@MiguelCastillo I think this will get it's way into master in the Pull Request burndown. |
|
@MiguelCastillo You've got a rouge CodeMirror submodule change in here. |
|
@dangoor @peterflynn any interest in reviving this? |
Main improvements:
I threw in two smaller tweaks as well: