This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Rewrite some logic in getTagInfo and getTagAttributes apis for CodeMirror updates in xml mode. #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l mode changes in CodeMirror.
| } | ||
|
|
||
| // If the ctx is inside the tag name of an end tag, innerModeData.state.tagName is | ||
| // undefined. So return token string as the tag name when the ctx is in an end tag. |
There was a problem hiding this comment.
"when the ctx is in an end tag" at the end of this comment is redundant, so it should be removed to simplify comment.
|
Done with initial review. |
|
@redmunds Changes are pushed. Ready for re-review. |
|
@RaymondLim There are merge conflicts, so you'll need to resolve those. Also, does this fix a particular bug? |
|
I'll try to resolve the conflict on my win 7 using the above command line tips. And yes, this also fixes #7541. |
|
@redmunds Done resolving the conflict in CodeMirror submodule. |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Apr 17, 2014
Rewrite some logic in getTagInfo and getTagAttributes apis for CodeMirror updates in xml mode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.