This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Allow for platform-specific font sizes #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| pre { | ||
| line-height: 15px; | ||
| } | ||
| } | ||
|
|
||
| .code-font-win() { | ||
| .code-font(); | ||
| font-size: 13px; |
There was a problem hiding this comment.
Can we add a comment here explaining the platform diff? E.g. "13px renders at basically the same size as 14px on Win but fixes glyph clipping issues (#440). But 13px is too small on Mac to use there."
There was a problem hiding this comment.
Good idea. Done.
|
Looks good other than that one comment nit. I tested on Win and verified that it does indeed fix the bug. |
|
Merging... |
peterflynn
added a commit
that referenced
this pull request
Mar 21, 2012
Fix issue #440 (text clipping on Win); allow for platform-specific font sizes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn
Addresses issue #440
Adding support for platform-specific fonts (and other css) by adding a "platform-mac" or "platform-win" class to the body tag.