Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Move the Update List information to a template #2938

Merged
merged 1 commit into from
Feb 28, 2013
Merged

Move the Update List information to a template #2938

merged 1 commit into from
Feb 28, 2013

Conversation

TomMalbran
Copy link
Contributor

While creating the contributors list I found a TODO on UpdateNotification about moving the HTML to a template, so I did that.

@ghost ghost assigned RaymondLim Feb 25, 2013
@RaymondLim
Copy link
Contributor

Nice work on converting update list info to a Mustache template. It took me a while to learn Mustache from your conversion. I tried your code in Sprint 19 and it works beautifully. So merging now.

RaymondLim added a commit that referenced this pull request Feb 28, 2013
Move the Update List information to a template
@RaymondLim RaymondLim merged commit 9c8d62f into adobe:master Feb 28, 2013
@TomMalbran
Copy link
Contributor Author

Thanks!

I've been working with Mustache for the past 2 months and is not that hard to do the conversions. Using {{.}} I can access each element in the update array, just because the data passed is an array and not an object. So in Mustache the code between {{#.}} and {{/.}} is executed for each element in the array and inside this code I can access each property of the object directly. Since newFeatures is an array, i did a for each but this time using {{#newFeatures}} since that is the name of the property, and once again inside this space i can access each property of the new features directly.

I could do the same with other templates, like Switch Language and Pref Data if is needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants