This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Split Handlebars into its own language #11295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give you a raw Handlebars mode without HTML syntax highlighting. This is how CodeMirror did it: CodeMirror.defineMode("htmlhandlebars", function(config) {
return CodeMirror.multiplexingMode(
CodeMirror.getMode(config, "text/html"),
{open: "{{", close: "}}",
mode: CodeMirror.getMode(config, "handlebars"),
parseDelimiters: true});
}); |
@marcelgerber Should be fine now. |
sprintr
force-pushed
the
cm-handlebars
branch
2 times, most recently
from
June 26, 2015 02:51
90c318c
to
08d2dc3
Compare
Looks good to me. The |
Why can't we load the mode in the extension? or do a trick like the one used for rpm: #11314? |
@marcelgerber What do you think about loading mode in the extension itself like in #11314 ? |
If that works, it's a whole lot cleaner. |
@marcelgerber Yeah, it works. I'll rebase and push. |
Travis CI build has passed. @marcelgerber Can you have a look at it |
This is all good & ready to go from my side. @ryanstewart Do we want this in 1.4 or should we wait for 1.5? |
Merging. |
abose
added a commit
that referenced
this pull request
Jul 30, 2015
Split Handlebars into its own language
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have enabled CodeMirror's simple-mode addon in the core, we should split handlebars mode, which uses simple-mode addon, into its own language.