Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Unit Tests] MultiBrowser tests fail on Mac/Safari #10124

Closed
redmunds opened this issue Dec 9, 2014 · 2 comments · Fixed by #10129
Closed

[Unit Tests] MultiBrowser tests fail on Mac/Safari #10124

redmunds opened this issue Dec 9, 2014 · 2 comments · Fixed by #10129
Assignees
@busykai
Labels
high priority Mac only
Milestone
Release 1.1

Comments

@redmunds
Copy link
Contributor

redmunds commented Dec 9, 2014

MultiBrowser (experimental) - Live Development tests fail on Mac OS X 10.8 with Safari 6.2

I guess I missed that this comment had not been addresses in original PR. Unit Test failures are High Priority, so we need to either fix these ASAP or disabled them.

cc @busykai @sebaslv
@redmunds redmunds added this to the Release 1.1 milestone Dec 9, 2014
@busykai busykai self-assigned this Dec 9, 2014
busykai added a commit that referenced this issue Dec 9, 2014
@busykai
Workaround for #10124: change the title on close.
500e420 
On Mac/OSX alert causes system modal dialog which prevents any interaction with
the browser and navigating away. This was causing unit tests to fail.

So instead of showing alert, change the title of the document to indicate that
the Live Preview session was closed. A more clear UI/UX definition is needed
for definitive solution.
@busykai busykai mentioned this issue Dec 9, 2014
Merged
@busykai
Copy link
Contributor

busykai commented Dec 9, 2014

@redmunds, with apologies for letting it slip in, created #10129 to address this.

redmunds added a commit that referenced this issue Dec 9, 2014
@redmunds
Merge pull request #10129 from adobe/kai/fix-mb-livedev-test-failures
0ebf373 
Workaround for #10124: change the title on close.
@redmunds
Copy link
Contributor Author

redmunds commented Dec 9, 2014

Confirmed. Closing.

@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@busykai busykai

Labels
high priority Mac only
Projects
None yet
Milestone
Release 1.1
Development

Successfully merging a pull request may close this issue.

Workaround for #10124: change the title on close. adobe/brackets
2 participants
@redmunds @busykai