Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Commit

Permalink
Remove Win-specific hacks from #4568 now that desired font weight is
Browse files Browse the repository at this point in the history
heavier across the board.
  • Loading branch information
peterflynn committed Oct 1, 2013
1 parent 27733fb commit 1660fd5
Showing 1 changed file with 2 additions and 19 deletions.
21 changes: 2 additions & 19 deletions src/styles/brackets_patterns_override.less
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
*
*/

/* Variable OVerride */
/* Variable Overrides */

@tooltipBackground: #fff;
@tooltipArrowColor: @tooltipBackground;
Expand Down Expand Up @@ -454,16 +454,6 @@ a:focus {
}
}

// Work around #4568: SourceSans is much fainter on Win than Mac, especially small text with "light" font-weight.
// We fix some of the most egregious cases by using a heavier font-weight only on Win (and because that's usually
// overkill, we also make the color paler to dial it back down a bit).
.less-faint-on-win() {
body.platform-win & {
font-weight: normal;
color: #2e2e2e;
}
}

.modal-body ul {
/* Bootstrap's type.less defines a heavy margin-bottom on ul/ol that we don't want in dialogs
since they have heavy padding instead. */
Expand Down Expand Up @@ -494,7 +484,6 @@ a:focus {
line-height: 20px;
margin-bottom: 20px;
font-weight: normal;
.less-faint-on-win();
}

.dialog-message li {
Expand Down Expand Up @@ -524,9 +513,6 @@ a:focus {
word-wrap: break-word;

font-weight: @font-weight-semibold;
body.platform-win & { // maintain contrast next to ".less-faint-on-win()" workaround
font-weight: @font-weight-semibold;
}
}

/* Any Dialog text in this style is automatically turned into a link that opens in the browser. Use href for the link's target. */
Expand Down Expand Up @@ -724,15 +710,13 @@ a[href^="http"] {
display: block;
font-size: 15px;
font-weight: normal;
.less-faint-on-win();
.user-select(text);
cursor: text;
}
.ext-desc {
width: auto;
color: @tc-text;
font-weight: normal;
.less-faint-on-win();
width: auto;
.user-select(text);
cursor: text;
}
Expand Down Expand Up @@ -811,7 +795,6 @@ a[href^="http"] {
.dialog-message {
font-size: 14px;
line-height: 17px;
.less-faint-on-win();

// Enable text selection
cursor: auto;
Expand Down

0 comments on commit 1660fd5

Please sign in to comment.