Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

implement MoveFileOrDirectoryToTrash on Linux #304

Merged
merged 1 commit into from
Aug 23, 2013
Merged

implement MoveFileOrDirectoryToTrash on Linux #304

merged 1 commit into from
Aug 23, 2013

Conversation

eyelash
Copy link
Contributor

@eyelash eyelash commented Aug 18, 2013

I tested (on Ubuntu 13.10):

  • deleting files
  • deleting directories

both worked

@ghost ghost assigned jasonsanjose Aug 19, 2013
@timburgess
Copy link
Contributor

I like the idea of using g_file_trash(). I've submitted some code for the same function in another PR but it's much more lower level C code and will only work with the Ubuntu trash. Using g_file_trash() there is more likely a chance that it will work with trash on other distros. If someone could test on a non-Ubuntu flavor that would be great.

@jasonsanjose
Copy link
Member

Linking to #284. Reviewing both.

@jasonsanjose
Copy link
Member

Looks good and tested on Ubuntu 13 64-bit after merging with master locally.

If I understand my libraries right...GIO is part of GLib. Since we require this in our debian package control file as a dependency, and presumably will require it for other distributions (Fedora is probably next), this should work across distributions right?

@eyelash it doesn't matter much currently since we don't have support for other distros yet. If you happen to know if this works on Fedora, just leave a note here.

Merging.

jasonsanjose added a commit that referenced this pull request Aug 23, 2013
implement MoveFileOrDirectoryToTrash on Linux
@jasonsanjose jasonsanjose merged commit 6c28945 into adobe:master Aug 23, 2013
@eyelash
Copy link
Contributor Author

eyelash commented Aug 23, 2013

GTK+ depends on GLib so every distribution that has GTK+ also has GLib. I don't use fedora but I'm quite sure this solution works for most of the distributions.

@jasonsanjose
Copy link
Member

Great. Thanks @eyelash. Also, thanks for signing the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants