Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for at.js and Web SDK mixed mode. The Adobe Target profile will now be preserved as a visitor moves between at.js and Web SDK pages. #895

Merged
merged 10 commits into from
Sep 19, 2022

Conversation

jonsnyder
Copy link
Contributor

@jonsnyder jonsnyder commented Jul 29, 2022

Description

As part of support for mixed mode. Include the Adobe Target mbox cookie in requests to experience edge. Alloy config includes a new targetMigrationEnabled setting for customers to indicate they are using mixed mode. For a first party domain, the cookie would be included automatically by the browser. For third party domains, we need to explicitly include this cookie in the request.

Related Issue

https://jira.corp.adobe.com/browse/PDCL-8236
https://jira.corp.adobe.com/browse/PDCL-8948

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

governing permissions and limitations under the License.
*/

export default (config, request) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't live in /utils because it isn't really a util. I would create a separate folder related to migration, where I would add all the legacy stuff we need for migration.

@jasonwaters
Copy link
Collaborator

LGTM @dcottingham

Copy link
Contributor

@carterworks carterworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

Copy link
Contributor

@ninaceban ninaceban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dcottingham 👍

@dcottingham dcottingham force-pushed the sendMboxCookie branch 2 times, most recently from a446aeb to 9dfac03 Compare September 15, 2022 00:37
Base automatically changed from legacyLocationHints to main September 19, 2022 16:21
Copy link
Contributor

@jfkhoury jfkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!

@jonsnyder jonsnyder merged commit e31938e into main Sep 19, 2022
@jonsnyder jonsnyder deleted the sendMboxCookie branch September 19, 2022 16:33
@jonsnyder jonsnyder changed the title Send legacy Adobe Target mbox cookie to experience edge for third party collection domains Support for at.js and Web SDK mixed mode. The Adobe Target profile will now be preserved as a visitor moves between at.js and Web SDK pages. Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants