-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for at.js and Web SDK mixed mode. The Adobe Target profile will now be preserved as a visitor moves between at.js and Web SDK pages. #895
Conversation
governing permissions and limitations under the License. | ||
*/ | ||
|
||
export default (config, request) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't live in /utils
because it isn't really a util. I would create a separate folder related to migration, where I would add all the legacy stuff we need for migration.
LGTM @dcottingham |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dcottingham 👍
64a31fb
to
af7478b
Compare
a446aeb
to
9dfac03
Compare
9dfac03
to
d324204
Compare
1492322
to
fe8fc2a
Compare
…ser migration to alloy
…rationEnabled=true is configured
d324204
to
1c40534
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes!
Description
As part of support for mixed mode. Include the Adobe Target mbox cookie in requests to experience edge. Alloy config includes a new
targetMigrationEnabled
setting for customers to indicate they are using mixed mode. For a first party domain, the cookie would be included automatically by the browser. For third party domains, we need to explicitly include this cookie in the request.Related Issue
https://jira.corp.adobe.com/browse/PDCL-8236
https://jira.corp.adobe.com/browse/PDCL-8948
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: