Added support for ECIDs passed via the adobe_mc query string parameter. Added appendIdentityToUrl command to enable cross-domain identity sharing. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts for cross-domain scenarios
This was referenced May 10, 2022
jonsnyder
commented
May 10, 2022
| @@ -14,7 +14,8 @@ import { boolean } from "../../utils/validation"; | |||
|
|
|||
| const configValidators = { | |||
| thirdPartyCookiesEnabled: boolean().default(true), | |||
| idMigrationEnabled: boolean().default(true) | |||
| idMigrationEnabled: boolean().default(true), | |||
| idOverwriteEnabled: boolean().default(true) | |||
There was a problem hiding this comment.
Do you think true is the right default?
There was a problem hiding this comment.
I think false might be a safer bet since that’s how it behaves today in Visitor.js
|
|
||
| const getDocumentCookie = ClientFunction(() => document.cookie); | ||
|
|
||
| test.skip("C5752639: Identity can be changed via the adobe_mc query string parameter when id_migration is enabled", async () => { |
There was a problem hiding this comment.
This test still fails. Waiting on Konductor changes to work.
jfkhoury
approved these changes
May 10, 2022
carterworks
approved these changes
May 10, 2022
… cross domain testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support legacy solution for passing ECID via the query string parameter adobe_mc. https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendvisitorid.html?lang=en
For the use case of navigating from one domain to another, the customer can use the "appendIdentityToUrl" command to generate the "adobe_mc" query string parameter. The command accepts an object with one property, "url", and returns an object with the property "url".
If consent has not been given, the url is returned unchanged. This command does not wait for consent.
If an ECID has not yet been established, "/acquire" endpoint will be hit to generate an ECID.
Added idOverwriteEnabled config to control whether the query string identity overwrites the cookie or not.
Related Issue
https://jira.corp.adobe.com/browse/PDCL-7572
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: