Fixed an issue where multiple persistent iframes were created for id syncs and segment destinations #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When firing off a referrer-hideable image for destinations and ID syncs, if there is not an
iframe
in memory, look in thedocument
for one before creating a new one.Related Issue
PDCL-8050 comment from Ian Ramsey.
Version 2.10.0 and PR #848 was supposed to restrict the Web SDK from creating one
iframe
per ID sync/segment destination, but the customer deployed it to their beta site (connect from a UK VPN location) and the issue was still there–manyiframe[name="Adobe Alloy"]
elements appeared.Motivation and Context
I am at a loss for why #848 did not solve the issue, but here we are.
Screenshots (if appropriate):
Screenshot of persistent issue on 2.10.0
Types of changes
Checklist: