Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where multiple persistent iframes were created for id syncs and segment destinations #859

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

carterworks
Copy link
Contributor

@carterworks carterworks commented Apr 26, 2022

Description

When firing off a referrer-hideable image for destinations and ID syncs, if there is not an iframe in memory, look in the document for one before creating a new one.

Related Issue

PDCL-8050 comment from Ian Ramsey.

Version 2.10.0 and PR #848 was supposed to restrict the Web SDK from creating one iframe per ID sync/segment destination, but the customer deployed it to their beta site (connect from a UK VPN location) and the issue was still there–many iframe[name="Adobe Alloy"] elements appeared.

Motivation and Context

I am at a loss for why #848 did not solve the issue, but here we are.

Screenshots (if appropriate):

Screenshot of persistent issue on 2.10.0 Screenshot of persistent issue on 2.10.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks changed the title Search doc for iframe when firing referrable-hideable image Search doc for iframe when firing referrer-hideable image Apr 26, 2022
@carterworks carterworks changed the title Search doc for iframe when firing referrer-hideable image Reduce race condition issues when looking for ID sync iframe Apr 26, 2022
@jonsnyder jonsnyder changed the title Reduce race condition issues when looking for ID sync iframe Fixed an issue where multiple persistent iframes were created for id syncs and segment destinations Apr 26, 2022
@shammowla shammowla self-requested a review April 27, 2022 15:01
@carterworks carterworks merged commit 6165956 into main Apr 27, 2022
@carterworks carterworks deleted the PDCL-8050 branch April 27, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants