Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force GitHub Actions npm cache reset #788

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

XDex
Copy link
Contributor

@XDex XDex commented Dec 3, 2021

Description

After merging #783, functional tests failed on main branch, due to npm cache not being reset after adding a new dev dependency.
This PR adds a mechanism for incrementing npm cache key value in GA workflows, so that it could be reset and functional tests would use the latest npm cache.
See this Cache Action issue for more context.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@XDex XDex requested a review from jonsnyder December 3, 2021 15:02
@XDex
Copy link
Contributor Author

XDex commented Dec 3, 2021

@jonsnyder Could you please take a quick look?
Thanks!

Copy link
Contributor

@ninaceban ninaceban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary spaces and add new lines at EOF where needed please.

@jonsnyder
Copy link
Contributor

@shammowla can you take a look? You are more familiar with these workflow files.

@XDex
Copy link
Contributor Author

XDex commented Dec 9, 2021

Remove unnecessary spaces and add new lines at EOF where needed please.

@ninaceban Not sure what you mean, the redundant spaces have been already cleaned up and newlines already added at EOF automatically by Idea in my commit, you've probably mixed up the removed (red) and added (green) mods when reviewing..

@XDex XDex requested review from ninaceban and shammowla December 9, 2021 21:57
@XDex XDex merged commit b89a364 into adobe:main Dec 17, 2021
@github-actions github-actions bot mentioned this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants