Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken click collector tests #1226

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

carterworks
Copy link
Contributor

Description

Fixes the tests to validateClickCollectionConfig that were missed in the migration and adds vitest __screenshot__ folders to the .gitignore

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks added the ignore-for-release Do not include this PR in release notes label Jan 16, 2025
@carterworks carterworks self-assigned this Jan 16, 2025
@carterworks carterworks merged commit ebab21e into main Jan 22, 2025
4 checks passed
@carterworks carterworks deleted the fix-click-collector-tests branch January 22, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants