Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an update script that helps to update the dispatcher configuratio… #966

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

froesef
Copy link
Contributor

@froesef froesef commented Jul 28, 2022

…n using a dispatcher SDK

This PR adds a script that helps users to update their dispatcher configuration files. It calls the update_maven.sh script of the given dispatcher SDK and updates the immutable files as well as the pom.xml checksums to the new values.

This will help customers when updating to new dispatcher versions and will make sure they see what configurations have been updated.

Related Issue

Motivation and Context

How Has This Been Tested?

By first creating a new project:

mvn -B org.apache.maven.plugins:maven-archetype-plugin:3.2.1:generate \
 -D archetypeGroupId=com.adobe.aem \
 -D archetypeArtifactId=aem-project-archetype \
 -D archetypeVersion=37-SNAPSHOT\
 -D appTitle="My Site" \
 -D appId="mysite" \
 -D groupId="com.mysite" \
 -D archetypeCatalog=local

And afterwards updating it's dispatcher configuration by running:

./update_sdk.sh /opt/dispatcher-sdks/dispatcher-sdk-2.0.113

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@froesef froesef requested a review from vladbailescu July 28, 2022 11:56
@krystiannowak krystiannowak self-requested a review July 28, 2022 12:40
@froesef froesef force-pushed the update-config-script branch from 1c860b1 to a22b51e Compare August 2, 2022 17:01
@froesef froesef force-pushed the update-config-script branch 2 times, most recently from 746f6f7 to d796289 Compare August 3, 2022 09:22
@froesef froesef force-pushed the update-config-script branch from d796289 to d4942b8 Compare August 3, 2022 09:23
@froesef froesef merged commit 09b5cf9 into adobe:develop Aug 3, 2022
@froesef froesef deleted the update-config-script branch August 3, 2022 11:37
@vladbailescu vladbailescu added this to the 39 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants