Add check if id of tab item is available #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add check if id of tab item is available before using it as selector to be backward compatible with customer code.
Codecov Report
@@ Coverage Diff @@
## main #2513 +/- ##
=========================================
Coverage 87.17% 87.17%
Complexity 2594 2594
=========================================
Files 229 229
Lines 6891 6891
Branches 1042 1042
=========================================
Hits 6007 6007
Misses 357 357
Partials 527 527 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
msagolj
approved these changes
May 25, 2023
bpauli
added a commit
that referenced
this pull request
May 25, 2023
- add check if id of tab item is available before using it as selector to be backward compatible with customer code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components which got inherit from a panel container but hasn't set the id of a panel container items are currently facing an issue with the change in #2408.
In this PR I added a check if the id is present before using it as part of the selector.